I'm almost positive we made it so because we had so much trouble when we were bringing up the mac and linux ports. I could be on crack tho....
On Tue, Jul 28, 2009 at 3:41 PM, Jeremy Orlow<[email protected]> wrote: > Was it ever a pre-submit check? > I filed http://crbug.com/15883 against myself a bit ago, but had trouble > making it work. I was going to work with Marc-Antoine this week to figure > it out. > J > > On Tue, Jul 28, 2009 at 11:13 AM, Darin Fisher <[email protected]> wrote: >> >> No idea. I was similarly burned by this. I wish it could be run as a >> presubmit check. >> -Darin >> >> On Tue, Jul 28, 2009 at 11:01 AM, Mike Pinkerton <[email protected]> >> wrote: >>> >>> We used to have to run: >>> >>> run_webkit_tests.sh --lint-test-files >>> >>> in order to check for duplicate WebKit layout test expectations. A >>> while back, this was turned into a pre-submit hook so we couldn't >>> forget to run it. However, in the last couple of days, both pkasting >>> and I have been tripped up by this. >>> >>> What happened? Did it get lost, or did we change our minds? >>> >>> -- >>> Mike Pinkerton >>> Mac Weenie >>> [email protected] >>> >>> >> >> >> > > > > > -- Mike Pinkerton Mac Weenie [email protected] --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
