Because mac doesn't have a fallback path to the windows results. So we could have put the same result file in win/linux/mac directories, but we do a small optimization and don't write the linux results because it falls back to windows results.
On Wed, Jul 29, 2009 at 3:52 PM, Evan Martin<[email protected]> wrote: > That sorta makes sense. But then why does it generate a mac baseline too? > > On Wed, Jul 29, 2009 at 3:18 PM, Tony Chang<[email protected]> wrote: >> >> This is a text only test (uses layoutTestController.dumpAsText()) so >> the Linux results should match windows exactly so we don't generate a >> Linux specific result. The test runner will fallback to the Windows >> result from Linux as well. You just need to verify that the results >> are correct on Windows and Mac (you can get these from the waterfall). >> >> On Wed, Jul 29, 2009 at 3:03 PM, Evan Martin<[email protected]> wrote: >>> >>> Starting with a clean tree, then running >>> ./webkit/tools/layout_tests/run_webkit_tests.sh --debug >>> --new-baseline LayoutTests/plugins/mouse-events.html >>> on Linux, it seems to overwrite the Mac/Win expectations. >>> % git ls-files --modified >>> webkit/data/layout_tests/platform/chromium-mac/LayoutTests/plugins/mouse-events-expected.txt >>> webkit/data/layout_tests/platform/chromium-win/LayoutTests/plugins/mouse-events-expected.txt >>> >>> Why? This seems very wrong. >>> >>> PS: It prints the following while running: >>> 090729 15:01:01 run_webkit_tests.py:1035 INFO Placing new baselines >>> in /work/chrome/src/webkit/data/layout_tests/platform/chromium-linux >>> which is where I'd expect the output to go. >>> >>> > >>> >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
