On Thu, Jul 30, 2009 at 12:13 PM, LivioSoares<livi...@gmail.com> wrote:
>
>
> Hi,
>
> I'm running Debian, with GCC 4.3.3 and am current getting a
> compilation error while compiling Chromium:
>
> cc1plus: warnings being treated as errors
> chromium/src/net/base/net_util.cc: In function
> 'bool<unnamed>::IsIDNComponentSafe(const char16*, int, const
> std::wstring&)':
> chromium/src/net/base/net_util.cc:641: error: suggest parentheses
> around assignment used as truth value
> scons: *** [chromium/src/sconsbuild/Release/obj/net/base/net_util.o]
> Error 1
>
> The code in question was introduced at revision 21963. The obvious
> patch (below) fixes the issue for me.
> However, without understanding the code, I can't be sure the typo as
> actually to change "=" to "==".
> Since we return 'safe', I assumed that the assignment was what was
> intended.
Thanks a lot for the patch. I think your patch is correct.
I will convert it to a changelist and ask jshin to review it.
Wan-Teh
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
