No, before it was treated as if the user always allowed it. Some file had a check that the download was denied if the dialog was NULL, but there's a stub dialog in temp_scaffoling_stubs that always pretends that the user clicks "yes", so that check was never triggered.
On Thu, Jul 30, 2009 at 2:35 PM, Evan Stade<[email protected]> wrote: > > On Thu, Jul 30, 2009 at 1:46 PM, Nico Weber<[email protected]> wrote: >> >> And another one for linux, by estade and me: Linux now has "carpet >> bombing" protection. Not too interesting, but since this counts as a >> security issue these days, you might want to mention it. > > actually we already had the protection right? Before we had the dialog > it was treated as if the user always denied it. So really, the new > functionality is that the user can choose to allow carpet bombing. > >> >> On Thu, Jul 30, 2009 at 12:08 PM, Evan Martin<[email protected]> wrote: >>> >>> One more for Linux, then, since it was especially annoying me and I >>> fixed it myself: >>> - dragging a tab off and dropping it puts the dropped window where you >>> dropped it >>> >>> On Thu, Jul 30, 2009 at 10:27 AM, Evan Martin<[email protected]> wrote: >>>> User-visible notes from skimming the Linux commits: >>>> - We now respect the system font hinting/antialiasing setting. >>>> - We now have a password manager dialog (Options -> Personal -> Show >>>> Saved Passwords). >>>> - Fixed an issue where scrolling a long page by dragging the scrollbar >>>> would lag significantly. >>>> >>>> (We've fixed many bugs but the third one's been reported within Google >>>> a few times, so I imagine it's affecting a lot of users. Though it's >>>> possible it's something specific to our hardware setup.) >>>> >>>> On Thu, Jul 30, 2009 at 10:15 AM, Anthony LaForge<[email protected]> >>>> wrote: >>>>> I'm in the process of building the release notes/ blog post for the 196.0 >>>>> release. I figured I'd try something a little different this week and >>>>> turn >>>>> over the process of picking high to the shiny folks on chromium-dev. I've >>>>> attached a filtered list of changes that were made to the 196.0 release >>>>> since 195.1 (between revisions 21177 and 21983). Please let me know if >>>>> there are any particulars that you'd like to see bubble up. Thanks in >>>>> advance for your help! >>>>> Kind Regards, >>>>> >>>>> Anthony Laforge >>>>> Technical Program Manager >>>>> Mountain View, CA >>>>> External Phone: 1-650-214-4055 >>>>> >>>>> >> >>>>> >>>> >>> >>> > >>> >> >> > >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
