Very nice, it passed all the try bot! I am adding Evan Marting and Evan Stade to the reviewers! Thanks for your patch! -- Mohamed Mansour
On Sun, Aug 2, 2009 at 11:11 PM, Anand Mistry <[email protected]> wrote: > Thanks to all. I didn't know about the try bot, so I've posted the patch > for review and I'm watching the buildbot. > > On Mon, Aug 3, 2009 at 12:15 PM, Joel Stanley <[email protected]> wrote: > >> Hello, >> >> On Mon, Aug 3, 2009 at 11:35, Anand Mistry<[email protected]> wrote: >> > Hi all, >> > I don't have the resources (disk space + tools) to compile my patch >> under >> > Windows and OSX, so can someone on this list quickly try it before I >> post it >> > for review? And on Windows, do a sanity check on the about:memory page. >> > Patch is attached. >> >> The linux memory reporting code is something I have been working on >> recently, thanks for taking it further. >> >> If you upload the patch to codereview.chromium.org, one of the >> chromium devs can submit it to the tryservers which build for all >> supported platforms. This process is also used for code review rather >> than submitting patches to the mailing list. >> >> http://dev.chromium.org/developers/contributing-code >> >> Cheers, >> >> Joel >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
