If making PostTask virtual will hurt performance, then so will making an
interface for PostTask that MessageLoop implements. Either way PostTask is
a virtual function call.
On Tue, Aug 4, 2009 at 11:39 PM, Jim Roskind <j...@chromium.org> wrote:
> +1 Darin
> +1 Maruel
>
> It was/is impressively hard to modify the message loop/pump without harming
> performance, and that performance is so central, that it tends to be visible
> in top level browser benchmarks.
> It was very difficult to make this body of code as simple(????) as it is.
> ...and it is not very simple. Please try not to add any complexity in what
> is seemingly super subtle code.
>
> Adding and calling through virtual methods may have some impact, and should
> be done very cautiously. Virtualizing existing methods, if they are
> mainstream, is pretty much guaranteed to impact performance.
>
> Adding interfaces, as proposed by Darin, would be seemingly risk free, at
> least in terms of performance.
>
> Jim
>
>
> On Tue, Aug 4, 2009 at 11:04 AM, Marc-Antoine Ruel <mar...@chromium.org>wrote:
>
>> On Tue, Aug 4, 2009 at 2:01 PM, Albert J. Wong (王重傑) <ajw...@chromium.org
>> > wrote:
>>
>>>
>>>>> On Tue, Aug 4, 2009 at 6:28 AM, Marc-Antoine Ruel <mar...@chromium.org
>>>>> > wrote:
>>>>>
>>>>>>
>>>>>> I'm slightly against. No real reason :) except that it'll definitely
>>>>>> bloat the WPO build.
>>>>>
>>>>>
>>> How bad would the bloat be?
>>>
>>
>> Please get data by building both with and without the virtual keyword in
>> official/wpo (not release) build.
>>
>> M-A
>>
>>
>>
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
