Which kind soul ended up working on this? Big thanks are in order, but I wanted to let you know that at least one case slipped through the cracks: http://src.chromium.org/viewvc/chrome?view=rev&revision=22556 required a clobber today. Any ideas why?
On Tue, Jul 28, 2009 at 4:46 PM, Nicolas Sylvain <[email protected]>wrote: > > > On Tue, Jul 28, 2009 at 4:37 PM, Evan Martin <[email protected]> wrote: > >> >> On Tue, Jul 28, 2009 at 4:35 PM, Paweł Hajdan >> Jr.<[email protected]> wrote: >> > On Tue, Jul 28, 2009 at 16:30, Evan Martin <[email protected]> wrote: >> >> >> >> This happens semi-frequently. It's related to the grit resources >> >> rebuilding. Something like: not remapping IDR_THROBBER_WAITING to the >> >> right place, or remapping it to the right place but not rebuilding >> >> this file, or something like that. >> > >> > Will the workaround for the original problem (clobbering headers >> generated >> > by .grd files) work also for this issue? If not, do you have any idea >> for a >> > fix or workaround? >> > Or maybe... why not set the resources projects to always-build, even >> just >> > for the buildbots? lastchange works this way, so it is possible. I think >> it >> > is not more or less crude than the clobbering workaround, and is simpler >> to >> > implement. Increase in the build time should not be significant (on the >> > bots; doing that on developers' machine probably isn't a good idea). >> >> I like the idea of always-building the resources project. >> Though note it can cause a lot of code to rebuild: it generates >> headers, which are included via includes via includes... > > > I still vote for the original idea of clobbering the .h files if the .grd > file is changed. I think it should be easy to implement with the DEPS file. > > The faster the incremental build is on the bots, the faster they cycle. > They are already too slow, that'd be sad to make it even slower. > > Nicolas > > >> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
