On Fri, Aug 7, 2009 at 8:47 AM, Thomas Van Lenten<[email protected]> wrote: > > On Fri, Aug 7, 2009 at 6:46 AM, Marc-Antoine Ruel <[email protected]> > wrote: >> >> On Thu, Aug 6, 2009 at 5:05 PM, Jeremy Orlow<[email protected]> wrote: >> > On Thu, Aug 6, 2009 at 2:02 PM, Nicolas Sylvain <[email protected]> >> > wrote: >> >> >> >> >> >> On Thu, Aug 6, 2009 at 1:05 PM, Scott Violet <[email protected]> wrote: >> >>> >> >>> Not sure, perhaps Huan could answer that. That said, --enable-dcheck >> >>> certainly works on the Chromium release builds from the buildbot: >> >>> http://build.chromium.org/buildbot/continuous/LATEST/ . >> >> >> >> Yes, --enable-dcheck is supposed to be disabled in Google Chrome build. >> > >> > Disabled or optimized out (so all that code isn't in the resulting >> > binary). >> > Hopefully the latter. >> >> Optimized out. > > Actually, it only goes away on Windows at the moment. > http://crbug.com/16512 > Quick summary from the bug: logging.cc uses a CPP symbol of OFFICIAL_BUILD, > which only exists in Windows builds (it's not in GYP it's in props files). > mmoss can also expand on what it would take to clean up/use OFFICIAL_BUILD > since I believe he's looked into that. Anyway, I made one run at getting it > to go away (CL and revert cl are in the bug), but the Mac build started > hanging in unittests when these got optimized away, I've made one pass > looking for things in DCHECKs that have side effects without any luck. > TVL
Once the multiple environment-variable-controlled configurations are integrated in the gyp configs, life will be easier. I haven't worked on that personally, I'm just whining. :) M-A --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
