Not that I know of. Too bad really...-BradN
On Thu, Aug 6, 2009 at 10:56 PM, Mohamed Mansour <[email protected]> wrote: > What is stopping us doing "Massive" line endings commit for all the files > in our repository in src/chrome. > +1 on the presubmit check! Is there a way to force Visual Studio > "Solutions" or "Projects" to always save line endings in LF generated via > gyp. > > -- Mohamed Mansour > > > > On Fri, Aug 7, 2009 at 1:48 AM, Bradley Nelson <[email protected]>wrote: > >> Yeah we should certainly handle this better.This was a known thing, but >> I've called it out in this gyp issue: >> http://code.google.com/p/gyp/issues/detail?id=38 >> >> I do like have consistent line endings, but the error message leaves >> something to be desired (not to mention being different on each platform >> :-). >> Shouldn't be a big deal to fix. >> >> -BradN >> >> >> On Thu, Aug 6, 2009 at 10:39 PM, Evan Martin <[email protected]> wrote: >> >>> I am a little surprised that Python's "eval" isn't line-ending agnostic. >>> This thread >>> >>> http://mail.python.org/pipermail/pythonmac-sig/2004-September/011638.html >>> suggests it doesn't like \r even on Windows and offers a simple >>> workaround when reading the file: >>> '\n'.join(s.splitlines()) >>> >>> On Thu, Aug 6, 2009 at 9:28 PM, Bradley Nelson<[email protected]> >>> wrote: >>> > Yes Mohamed, please do. Which files had the dos line endings? >>> > We should really add a presubmit check... >>> > -BradN >>> > >>> > On Thu, Aug 6, 2009 at 9:22 PM, Mohamed Mansour < >>> [email protected]> >>> > wrote: >>> >> >>> >> Ah thank you Dan! It worked! I guess I should commit the line ending >>> then? >>> >> -- Mohamed Mansour >>> >> >>> >> >>> >> On Fri, Aug 7, 2009 at 12:17 AM, Dan Kegel <[email protected]> wrote: >>> >>> >>> >>> Please check to make sure the python scripts have UNIX >>> >>> line endings, not DOS ones. >>> >> >>> >> >>> >> >>> > >>> > >>> > >>> > >>> > >>> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
