Thanks for the speedy response guys. I got the impression chrome-resource
is coupled to the new tab page from stuff like this:
// Special case the new tab page. In older versions of Chrome, the new tab
// page was hosted at chrome-internal:<blah>. This might be in people's
saved
// sessions or bookmarks, so we say any URL with that scheme triggers the
new
// tab page.
if (url.host() == chrome::kChromeUINewTabHost ||
url.SchemeIs(chrome::kChromeInternalScheme)) {
if (new_ui)
*new_ui = new NewTabUI(tab_contents);
return true;
}
Maybe we could add a deeper check before this and make it work. I seem to
remember trying to use chrome-resource in the past and running into other
problems, due to it being coupled to specific components. It might have
been hard just because I didn't want to add #ifdefs all over the place, so
it's worth another shot.
And sounds like changing the gears:// scheme isn't so easy. I can at least
try to factor "is html dialog URL" conditions into a common function
someplace.
On Thu, Aug 13, 2009 at 1:36 PM, Adam Barth <[email protected]> wrote:
> We should avoid proliferating more magical schemes. Please consider
> reusing existing schemes, such as chrome-resource. If you do add
> schemes, please consider registering them in
> ChildProcessSecurityPolicy.
>
> Adam
>
>
> On Thu, Aug 13, 2009 at 1:26 PM, Tim Steele<[email protected]> wrote:
> >
> >
> > On Thu, Aug 13, 2009 at 1:18 PM, Tim Steele <[email protected]> wrote:
> >>
> >> and use a RenderViewHost directly. The personalization code used to do
> >> something like this using a thing I added called HWNDHtmlView. I think
> >> extensions used it for a while, and there was a bug+todo there to try
> and
> >> extend it's usefulness, but it went the way of the dodo bird in r16392 .
> >
> > Oops, wrong link. r16392
> > > >
> >
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected]
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
