On Wed, Aug 19, 2009 at 1:23 PM, Darin Fisher<[email protected]> wrote: > On Wed, Aug 19, 2009 at 1:14 PM, Evan Martin <[email protected]> wrote: >> >> Rad that you're doing this! >> >> I think that we shouldn't have any linux-specific directories except >> for one or two cases where it's *really* Linux-specific (like crash >> dumping or ). So the same should be true for you. >> >> It seems the configurations we'll see most frequently in code are: >> 1) POSIX (basically, non-Windows -- we have this already) >> 2) POSIX minus Mac (since Mac has the most extensions, especially at >> the GUI layer) >> 3) POSIX minus Linux (aka everything BSD-derived, more or less) >> >> Dean proposes a define for #2, agl proposes a define for #3. I think >> it'd be nice to keep the defines down if possible. >> >> I wonder if #2 could be covered by OS_POSIX && TOOLKIT_GTK. Or, > > What about TOOLKIT_VIEWS?
Darin is right. There is actually a #4 on Evan's list: POSIX minus Mac minus Views. I did a search for every place we use OS_LINUX. They fall into a couple of cases: - Graphics stuff like X-windows & fonts that are shared between TOOLKIT_GTK and TOOLKIT_VIEWS on Linux. - File path handling stuff. Here Linux/BSD are different from Mac, because there is no encoding, while Mac defines one. - Low level stuff like threads, where Mac has something fancy, but we want to use pthreads or whatever on Linux - A very few system info queries that are likely different between Mac, Linux, and *BSD. Maybe this also includes crash reporting? - Some that should be TOOLKIT_GTK instead of OS_LINUX It looks like the vast majority of them fall into the first two categories (graphics and file paths). It would be nice to optimize our ifdefs so these common ones don't get more complicated. Brett --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
