Actually, I found two:
thumbnail_store_unittest.cc:134: std::cout << "Max diff btwn original
and encoded image (b,g,r,a) = ("v8_unit_test.cc:91: std::cout <<
message << "\n";
- a
On Tue, Sep 1, 2009 at 10:49 AM, Aaron Boodman <[email protected]> wrote:
> Yeah, no problem. Do you have the test in question off hand?
>
>
> On Tue, Sep 1, 2009 at 10:46 AM, Marc-Antoine Ruel <[email protected]>wrote:
>
>> That's fine, we simply filter to ERROR by default.
>> Can you change it to ERROR (if that's what you think it is)
>>
>> Thanks,
>>
>> M-A
>>
>>
>> On Tue, Sep 1, 2009 at 10:44 AM, Aaron Boodman <[email protected]> wrote:
>>
>>>
>>>
>>> On Tue, Sep 1, 2009 at 10:43 AM, Aaron Boodman <[email protected]> wrote:
>>>
>>>> Sorry. I tried LOG(INFO) and LOG(WARNING) and neither worked. I then
>>>> jumped to just using std::cout.
>>>> - a
>>>>
>>>>
>>>> On Tue, Sep 1, 2009 at 10:40 AM, Marc-Antoine Ruel <[email protected]
>>>> > wrote:
>>>>
>>>>> Please never use std::cout in unit tests. Use LOG(ERROR) if you want
>>>>> to output debug information about internal error state. That will log
>>>>> the correct process id.
>>>>>
>>>>> The reason is dead simple, it makes automatic log processing hard and
>>>>> Pawel's regexp miserable.
>>>>>
>>>>> If you still want to use cout, at least please use \n or std::endl.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> M-A
>>>>>
>>>>
>>>>
>>>
>>
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected]
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
