Seems good. Nice job! I hope it will eradicate this kind of flakiness. On Thu, Sep 3, 2009 at 17:37, Bradley Nelson <[email protected]> wrote:
> Hi Pawel, > I'm in the process of landing a change which will add grit_info.py, which > will let you list all of the inputs and outputs from a .grd file. > Initially I'll be using the inputs to fix some of the dependencies. Does > this cover your concerns? > > http://codereview.chromium.org/197007/show > > -BradN > > > On Thu, Sep 3, 2009 at 5:30 PM, Paweł Hajdan Jr. > <[email protected]>wrote: > >> The flakiness with resources has hugely decreased since I landed my >> infamous hook, but it's still there. >> I'm not sure what really happens, so I'm thinking about a special build >> step (before UI tests etc), which would verify that all the expected >> resources are present in the bundle and then fail. That is more easily >> recognizable than a flaky test failure, and clearly indicates a bug in the >> build system (and hopefully the right commit). >> >> The question is - how to enumerate all claimed resources? Is looking at >> all .grd files sufficient? >> >> >> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
