Putting HTML in the commit message doesn't sound good to me (or does your patch work differently?). Plain text is good in this case. And rewriting the commit message is risky as well (at least I should get a chance to see the rewritten message before it gets committed). On the other hand, maybe it would make more sense to autolink the BUG line in other places: buildbot waterfall, viewvc, ...
On Thu, Sep 10, 2009 at 15:03, Mohamed Mansour <[email protected]> wrote: > I did the git and gcl patches, but it only does it when you "commit". What > ways do you guys like to use it? jam stated that he is opposed to changing > the commit log from what the person wrote. > - Mohamed Mansour > > > > On Thu, Sep 10, 2009 at 5:29 PM, Mohamed Mansour <[email protected]> wrote: > >> Np! I will do one for gcl. >> -- Mohamed Mansour >> >> >> >> On Thu, Sep 10, 2009 at 3:31 AM, John Abd-El-Malek <[email protected]>wrote: >> >>> This is just for Rietveld issues. We can possibly do the same to the >>> commit log in gcl/git scripts, again patches welcome :) >>> Thanks Mohamed for the patch, I committed it and made it live with two >>> minor changes. >>> >>> >>> On Wed, Sep 9, 2009 at 10:04 PM, PhistucK <[email protected]> wrote: >>> >>>> Are we only talking about when it is viewed in Rietveld?What about when >>>> it is actually committed, can the change log be tweaked that way, >>>> automatically, too? >>>> That would be nice when reading change logs. >>>> >>>> Thank you! >>>> >>>> ☆PhistucK >>>> >>>> >>>> >>>> On Thu, Sep 10, 2009 at 05:01, John Abd-El-Malek <[email protected]>wrote: >>>> >>>>> Thanks, glad you enjoy it :) >>>>> This was a side distraction to fix the annoying issue of having to >>>>> manually copying and pasting the bug ids. It severely tested my regex-fu >>>>> and since the multiple bugs case should be rare, I'll hide behind the >>>>> excuse >>>>> that if they're duplicates they should be marked as such and only end up >>>>> with one, and if they're different bugs there should be separate >>>>> changelists >>>>> ;) The rietveld change is at >>>>> http://code.google.com/p/rietveld/source/detail?r=455, if anyone sends >>>>> me a patch to make it work with multiple bug ids, I'd be happy to push it. >>>>> >>>>> >>>>> On Wed, Sep 9, 2009 at 6:15 PM, Mohamed Mansour <[email protected]>wrote: >>>>> >>>>>> Very nice, no longer I have to put crbug.com/#. Whoever did that >>>>>> autolink, can you support multiple bugs as well? The format bugdroid >>>>>> uses is >>>>>> BUG=1, 2, 3 >>>>>> - Mohamed Mansour >>>>>> >>>>>> >>>>>> >>>>>> On Wed, Sep 9, 2009 at 8:58 PM, Paweł Hajdan Jr. < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> I just noticed that BUG=1234 lines are autolinked to the correct bug >>>>>>> when viewed in Rietveld (codereview.chromium.org). This is very >>>>>>> useful, thanks! >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> >>>> >>>> >>>> >>>> >>> >> > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
