On Tue, Sep 15, 2009 at 4:26 AM, Dirk Pranke <[email protected]> wrote: > > Hi all, > > I have just landed a patch that enables us to run layout tests on > Vista as well as XP. > > In theory, you should continue to use the tools just as you have in > the past, and everything will work transparently. In practice, I may > have screwed up something, so if you notice problems please let me > know. > > One important change is that we now have a few XP-specific baselines > in webkit/data/layout_tests/platform/chromium-win-xp (mostly in the > way we handle various international characters and font differences > between XP and Vista). We do not have any Vista-specific baselines > (although one could argue that if there is a baseline in chromium-win > and a baseline in chromium-win-xp then the chromium-win one is > Vista-specific). We will be following the WebKit convention that the > generic platform directory represents the "most recent" version of the > platform (meaning that until Win 7 is released, all Vista baselines go > in chromium-win. When Win 7 is released, Vista-specific baselines will > go in chromium-win-vista). > > In practice, this means you might need to be careful about where your > new baselines end up when using the rebaselining tool. You should make > sure they end up in chromium-win unless you are sure they are > XP-specific (in which case you will be responsible for landing > baselines for both XP and Vista). > > If you have any questions about this, or run into problems, please let > me know ASAP. > > One last thing for those who might look at this stuff in detail - > test_shell has been changed to use a "generic" theme for rendering > form controls, scroll bars, and other native widgets, in order to not > have any differences from the different themes on the different > versions of Windows. If you are wondering why the scroll bars and > other controls in the baselines look really odd, that's why. Also, the > checkin involved updating > 700 images, so I didn't have anyone but me > review them. Let me know if you see anything that doesn't look right > :) > > Also, we will probably be landing Win 7 baselines Real Soon Now, since > adding them is a very small additional amount of work on top of the > stuff I just landed.
Hm, now I have no excuse for not running the layout tests :( Thanks for working on this, though! Brett --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
