Yes, I was poking this a little bit last week, and a little bit the week before. It seems that under Valgrind, tests involving the pasteboard, and maybe a couple of other things too, will always fail. In some cases, the test failures result in certain things not being cleaned up, which in turn results in something that Valgrind detects as a leak at the end of the run. I tried to fix some of these so that at least the tests always clean up after themselves, but was only partially successful. The underlying issue here is that the tests are failing, but only under Valgrind.
Nico Weber wrote: > [----------] Global test environment tear-down > [==========] 981 tests from 219 test cases ran. (908043 ms total) > [ PASSED ] 978 tests. > [ FAILED ] 3 tests, listed below: > [ FAILED ] AutocompleteTextFieldEditorTest.CutCopyTest > [ FAILED ] BookmarkEditorControllerTest.UserEditsStuff > [ FAILED ] DownloadUtilTest.AddFileToPasteboardTest > > However, the tests work fine on the other bots and locally, they only > fail on the valgrind builder. Which is however still green. The Valgrind test step doesn't turn red for test failures, only for unsuppressed leaks. I wanted to ask dank about that last week, but he wasn't around when it initially upset me, so I moved on. Let's ask him now. dank? Mark --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
