As a dictator, I say the rule is simple; Is the .sln/.vcproj actually used in all.sln? - If not, we don't care and can leave the file as-is. We assume it's in third parties only. - If so, it needs to be converted.
When we add new build "flavors" (purify, pgo, etc), it's a pain to manage non-gyp vcproj so if a .vcproj is used, it should be converted. I updated the doc to clarify this. M-A On Thu, Oct 1, 2009 at 12:44 AM, Darin Fisher <[email protected]> wrote: > Looking over that list, it seems that some of them are for Windows only > things, and as such, conversion to GYP would probably be gratuitous. We > should continue allowing .sln files in the tree. > -Darin > > > On Wed, Sep 30, 2009 at 9:43 PM, Darin Fisher <[email protected]> wrote: >> >> We shouldn't have anymore .sln files in the tree :-) >> However, I still see quite a few: >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/build/icudt_build.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/allinone/allinone.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/all/all.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/break/break.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/cal/cal.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/case/case.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/coll/coll.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/date/date.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/datefmt/datefmt.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/layout/layout.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/legacy/legacy.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/msgfmt/msgfmt.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/numfmt/numfmt.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/props/props.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/strsrch/strsrch.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/translit/translit.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/uciter8/uciter8.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/ucnv/ucnv.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/udata/udata.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/ufortune/ufortune.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/ugrep/ugrep.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/uresb/uresb.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/samples/ustring/ustring.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/test/letest/cletest.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/test/letest/gendata.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/test/letest/letest.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu38/source/test/perf/perf.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu42/build/icudt_build.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu42/source/allinone/allinone.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu42/source/test/letest/cletest.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu42/source/test/letest/gendata.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu42/source/test/letest/letest.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/deps/third_party/icu42/source/test/perf/perf.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/src/o3d/core/win/core_unittests.sln >> /home/chrome-svn/codesearch/chrome/trunk/src/o3d/plugin/win/o3dPlugin.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/src/sandbox/sandbox_standalone.sln >> /home/chrome-svn/codesearch/chrome/trunk/src/sandbox/wow_helper.sln >> /home/chrome-svn/codesearch/chrome/trunk/src/testing/gmock/msvc/gmock.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/src/third_party/npapi/npspy/windows/npspy.sln >> >> /home/chrome-svn/codesearch/chrome/trunk/src/tools/channel_changer/channel_changer.sln >> -Darin >> >> >> On Wed, Sep 30, 2009 at 8:25 PM, Mark Larson (Google) <[email protected]> >> wrote: >>> >>> http://dev.chromium.org/developers/coding-style >>> There's a section on Subversion properties that looks like it predates >>> GYP. It says to set *.sln = svn:eol-style=native when I would expect it to >>> be in global-ignores. >>> Can someone with a good idea of what the defaults should be update this >>> page? >>> --Mark >>> Filed as http://bugs.chromium.org/23519 >>> >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
