OK let's make the change for multiple downloads, but not for protocols. If you fix the bug on linux, please make sure the bug is filed for mac/windows. Thanks!
-Ben On Tue, Oct 6, 2009 at 3:37 PM, Evan Stade <est...@chromium.org> wrote: > On Tue, Oct 6, 2009 at 3:18 PM, Glen Murphy <g...@chromium.org> wrote: >> >> Multidownload infobar SGTM, though I'm pretty sure I've seen the >> multiple download dialog appear after user input (could be for >> downloads initiated via JS or iframe POSTS). > > The multidownload dialog is launched specifically when there was a download > started without user input, where "user input" == enter, space or click > anywhere in the page, so it doesn't matter by which mechanism the download > is initiated; it just matters whether the user did something. This is of > course racy and heuristic. > >> >> External protocol dialog should remain a dialog - I see it whenever I >> click on links to stuff in the iTunes store, and having it show as an >> infobar would be unpleasant. >> >> >> > Chatted briefly w/Brian he seemed to agree about multiple download >> > dialog, Glen what do you think? >> > >> > -Ben >> > >> > On Tue, Oct 6, 2009 at 3:02 PM, Evan Stade <est...@chromium.org> wrote: >> >> On Tue, Oct 6, 2009 at 1:12 PM, Ben Goodger (Google) <b...@chromium.org> >> >> wrote: >> >>> >> >>> We should only use infobars for things that aren't initiated by a user >> >>> action. They are very confusing for user initiated actions since they >> >>> are harder to notice. >> >>> >> >>> In each of these cases, can you determine whether or not a user action >> >>> caused them? >> >> >> >> for the multiple download dialog, a user action definitely did not >> >> cause it. >> >> for the external protocol handler, a user action usually did cause it >> >> (but >> >> sometimes not). I don't think there's any way of knowing for sure. >> > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---