On Sat, Oct 10, 2009 at 1:55 PM, Brett Wilson <[email protected]> wrote:
> First, please consider putting it inside your component's directory.
> When everybody adds all their crap to base, it ends up that nobody can
> find anything and the build is more interdependent. If you're not
> actually sharing anything between toplevel projects, it shouldn't be
> in base.
string_util is one of the worst in base:
% wc -l base/*.h | sort -n | tail -10
500 base/time.h
514 base/tracked_objects.h
519 base/message_loop.h
538 base/file_util.h
587 base/string_util.h
588 base/histogram.h
677 base/task.h
823 base/logging.h
907 base/tuple.h
But for the project, it's not too bad:
% git ls-files "*.h" | egrep -v
'third_party|generated|gmock|syscall_support' | xargs wc -l | sort -n
| tail -10
1150 ipc/ipc_message_macros.h
1168 chrome/browser/tab_contents/tab_contents.h
1239 views/view.h
1270 ipc/ipc_message_utils.h
1326 chrome/browser/sync/syncable/syncable.h
1921 chrome/common/render_messages_internal.h
2116 tools/traceline/traceline/syscall_map.h
2173 chrome/common/render_messages.h
3323 o3d/command_buffer/common/cross/cmd_buffer_format.h
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: [email protected]
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
