On Tue, Oct 13, 2009 at 6:02 PM, Evan Stade <[email protected]> wrote:
> > 3. It is unclear if there are any layout tests which cover this change. >> > > I don't think layout tests can or should cover that change, except for > pixel tests, which will just need to be rebaselined. > Right so are there pixel tests which cover this? Maybe that isn't possible. WebKit patches should say one of the following about (layout) tests: 1. what tests cover the functionality 2. have new tests that cover the functionality 3. explain why a test isn't needed 4. explain why a test isn't possible This patch does none of those which is what I was attempting to point out in a less verbose manner. dave --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
