This was fixed in r28916. -Scott
-Scott On Wed, Oct 14, 2009 at 2:13 AM, James Su <[email protected]> wrote: > Hi, > I managed to build a chromium with "toolkit_views=1", however it crashes > when inputting anything in location entry. Digging into the code I found in > views/widget/widget_gtk.cc: > > void WidgetGtk::Init(GtkWidget* parent, > const gfx::Rect& bounds) { > if (type_ != TYPE_CHILD) > ActiveWindowWatcherX:: > AddObserver(this); > // Force creation of the RootView if it hasn't been created yet. > GetRootView(); > > #if !defined(OS_CHROMEOS) > default_theme_provider_.reset(new DefaultThemeProvider()); > #endif > ... > > Then default_theme_provider_ will be NULL when OS_CHROMEOS is defined, and > seems that it's defined when using "toolkit_views=1". However, there are > many places call WidgetGtk::GetThemeProvider() and access the theme provider > without check, thus cause crash. I'm wondering if it's a bug or I did > something wrong? > > Regards > James Su > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
