I think it's very helpful to review your nib diffs for inadvertent changes. It's annoying, because nib files are pretty opaque, but often you'll find a bunch of unrelated crap like slight window movements. I use git, and during development I try to isolate the nib changes with descriptive CLs, so that once I'm happy, I can revert my nib changes to the trunk and try to create a minimal nib change. If all you did is change a setting on a control, you shouldn't have 39 differences in your nib.
-scott On Fri, Oct 16, 2009 at 11:16 AM, Avi Drissman <[email protected]> wrote: > I've seen many a CL containing changes to nib/xib files, and given that > those files are machine-generated XML, it's not immediately obvious what the > changes are. That's problematic for several reasons, two of which > immediately come to mind: > > 1. You can't adequately review the CL if you don't know what was done. > Inspection works for simple changes, but not for large ones. > 2. Nib/xib file patches bitrot extremely quickly and hand-merging is > near-impossible. If a merge needs to happen (either someone else needs to > land the code, or perhaps you do), sometimes the easiest way to merge is to > just re-create the changes on the new ToT file, which is not possible if you > don't know what was done. > > Thus my request. In any CL that changes a nib/xib file, can you please > provide a (brief) description of the change? > > Avi > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
