Shameless "reply" in hopes of getting some pointer after all. (And don't hesitate to tell me in case the whole question is mauve! ^_-). Cheers,
Roland On Wed, Oct 14, 2009 at 1:34 PM, Roland Steiner <[email protected]>wrote: > In my implementation for PlainTextController (see > http://codereview.chromium.org/243032) for the test shell I have run into > some issues for which I'm not sure what's the best way to address them. > Thusly I wanted to ask around if someone could give me some pointers: > .) The implementation of PlainTextController::plainText() should check > whether the passed-in argument is indeed a range. At the moment I have a > test (not yet submitted) that looks for a range-specific method, using > WebKit::WebBindings::hasMethod("setStartBefore") that seems to > work. However, this is rather hackish. The WebKit (Mac) version of > PlainTextController uses 'isKindOfClass'. Is there a way to emulate this, or > another workaround that is more elegant than what I described above? > > .) To retrieve the result, my current implementation invokes "toString". > For parity with the WebKit implementation of PlainTextController > however, PlainTextController::plainText() should rather use a special text() > method on range that is not exposed in the IDL. As I don't think extending > the IDL is an option, is there a way to "cast" a NPObject to a WebRange > object so that I can call the function directly? > > Any pointers and suggestions would be very helpful. > > > Cheers, > > Roland > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
