On Wed, Nov 11, 2009 at 10:40 PM, Paweł Hajdan Jr.
<phajdan...@chromium.org>wrote:
> On Thu, Nov 12, 2009 at 01:00, John Abd-El-Malek <j...@chromium.org> wrote:
>
>> On Wed, Nov 11, 2009 at 1:22 PM, Paweł Hajdan Jr. <
>> phajdan...@chromium.org> wrote:
>>
>>> To do that, I'd need to listen for BlacklistManager notifications in RDH
>>> (on IO thread). Does it seem OK to make RDH a NotificationObserver and use
>>> NotificationRegistrar inside?
>>>
>>
>> The part about making RDH a NotificationObserver sounds fine. However, if
>> you block all requests from even starting until BlackListManager is ready,
>> you're basically delaying the IO thread until the data is loaded anyways, so
>> it doesn't seem that making it happen asynchronously buys much.
>>
>
> The problem is that for example a privacy blacklist may prevent a request
> for sending the referrer. Another thing they can block are cookies. That
> means that probably the only thing we can do before all blacklists are
> loaded is connecting to the host (which is still a win). Is it possible to
> do that using ResourceHandlers?
>
I think it would depend on when in the connection phase that the
ResourceHandler tries to do this.
>
> And of course the performance of loading blacklists from disk is considered
> to be critical. They are stored in one binary file on disk, in a simple
> format.
>
My question still stands: if this list is needed in order to process the
first network request, why add extra complexity to RDH to make more things
asynchronous, when either way any IO is basically blocked on the blacklist?
You might as well load the list on the IO thread.
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
