That's good to hear! I see you are mainly just turning off warnings as errors in a few spots. Is this something that we can either gate in the build based on some flag, or are the warnings something that we could fix properly in the source? I'd love to peel off more steps from the process.
-BradN On Mon, Nov 16, 2009 at 5:44 PM, Dominic Jodoin <dominic.jod...@gmail.com>wrote: > Hey Brad! > > I just wanted to let you know that this is working great for me on > VC++ 2008 Express Edition. Thanks a lot! > > I have updated my page to reflect your change. I also added a patch > that modifies some GYP files in such a way that you won’t have to > manually “play” with the project settings in order to compile without > errors (with this compiler that is). > > > http://cotsog.wordpress.com/2009/11/08/how-to-compile-google-chrome-with-visual-c-2008-express-edition/ > > -- Dominic. > > On Thu, Nov 12, 2009 at 7:51 PM, Bradley Nelson <bradnel...@google.com> > wrote: > > Ok that fix is in. > > You'd need to set GYP_MSVS_VERSION=2008e > > Let me know how that goes for you. > > -BradN > > > > On Wed, Nov 11, 2009 at 12:50 PM, Marc-Antoine Ruel <mar...@chromium.org > > > > wrote: > >> > >> Updated > >> > http://sites.google.com/a/chromium.org/dev/developers/how-tos/build-instructions-windows > >> to reference your blog entry. > >> > >> I don't want to copy these instructions since it's too lengthy, > >> inefficient and unsupported. > >> > >> I didn't realize one could download WDK 7 without needing a MSDN > >> account. That's cool. > >> > >> M-A > >> > >> On Tue, Nov 10, 2009 at 10:39 PM, Dominic Jodoin > >> <dominic.jod...@gmail.com> wrote: > >> > On Tue, Nov 10, 2009 at 10:25 PM, Peter Kasting <pkast...@google.com> > >> > wrote: > >> >> > >> >> What do you mean? Or to be more precise, what would considering your > >> >> steps > >> >> "a valid setup to contribute" concretely result in? > >> >> PK > >> > > >> > I'm wondering if using a hacked ATL version 7.1 could lead to bugs > >> > given the product is built, I suppose, with ATL coming with Visual > >> > Studio 2005 or 2008 which is a different version. > >> > > >> > But what I meant was that if the steps were to be approved, I thought > >> > they could be included on http://dev.chromium.org. > >> > > >> > -- Dominic. > >> > > >> > -- > >> > Chromium Developers mailing list: chromium-dev@googlegroups.com > >> > View archives, change email options, or unsubscribe: > >> > http://groups.google.com/group/chromium-dev > >> > > >> > >> -- > >> Chromium Developers mailing list: chromium-dev@googlegroups.com > >> View archives, change email options, or unsubscribe: > >> http://groups.google.com/group/chromium-dev > > > > > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
