It's been brought to my attention that this change might cause merge pain for folks trying to pull their changes into the M4 branch. I can wait to do this until a later date, or I suppose bring the change over to M4?
Anybody feel super strongly? -BradN On Thu, Nov 19, 2009 at 9:57 AM, Bradley Nelson <bradnel...@google.com>wrote: > That might be worth considering. > The reason they're gypi's instead of regular gyp files is because xcode > presents only whole gyp's to the developer. > Putting them in gypi's was a compromise which keep the final xcodeproj in > one piece. > If we move the gypi's to subdirectories, paths in them will still be > relative to src/chrome, which might be confusing. > > I would prefer if gypi's didn't have this behavior, and plan to fix it: > http://code.google.com/p/gyp/issues/detail?id=116 > > In the meantime, does moving them still make sense? Or shall I wait under > after? > > -BradN > > > On Wed, Nov 18, 2009 at 9:34 PM, Darin Fisher <da...@chromium.org> wrote: > >> Sounds like a good change, but did you consider putting these gypi files >> in the subdirectories? chrome/renderer/renderer.gypi, etc. seems like it >> would be nice. >> >> -Darin >> >> >> On Wed, Nov 18, 2009 at 7:02 PM, Bradley Nelson >> <bradnel...@google.com>wrote: >> >>> Hello All, >>> >>> I've just landed a change which splits src/chrome/chrome.gyp in to >>> several pieces: >>> chrome.gyp >>> chrome_browser.gypi (browser) >>> chrome_common.gypi (common) >>> chrome_debugger.gypi (debugger) >>> chrome_plugin.gypi (plugin) >>> chrome_renderer.gypi (renderer) >>> chrome_tests.gypi (almost all tests) >>> >>> You can treat these additional gypi's as if they were a part of >>> chrome.gyp, everything is still relative to src/chrome. >>> >>> I'm not wedded to this division, but I've tried to carve off large enough >>> chunks to reduce the contention on chrome.gyp. >>> Because these are all gypi includes, nothing should change in the layout >>> of the project files. >>> >>> -BradN >>> >>> -- >>> Chromium Developers mailing list: chromium-dev@googlegroups.com >>> View archives, change email options, or unsubscribe: >>> http://groups.google.com/group/chromium-dev >>> >> >> > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
