On Thu, Nov 19, 2009 at 12:56 PM, Paweł Hajdan Jr.
<phajdan...@chromium.org> wrote:
> It turns out that WATCHLISTS aren't fully effective because git-cl doesn't
> support them. It doesn't look very hard to implement the support for git-cl
> because there is already a watchlists.py file, but then there are some
> questions:
> - should the watchlists.py file (from depot_tools) be copied to the git-cl
> repo or should git-cl try to locate it (upload.py is copied)

Can we hook it into the PRESUBMIT script instead?  That seems cleaner to me.

> - should watchlists.py be integrated into upload.py (probably not)?

The metric I use is: is this something used by other users of git-cl?
I think watchlists are not.

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev

Reply via email to