On Sat, Nov 21, 2009 at 12:33 PM, Peter Kasting <pkast...@google.com> wrote:
> On Sat, Nov 21, 2009 at 12:06 PM, Evan Martin <e...@chromium.org> wrote: > >> This works for warnings we know about now, but not warnings that will >> occur in the future, which is the larger problem. >> I'd say we break the automated Ubuntu builds every couple of weeks >> (and get an additional report from users at about that same rate). >> > > What I'm concerned about is that occasionally these warnings may be real > and useful, rather than always being stupid. It seems like each warning > should be something we at least take a look at to make sure it's not a > concern, which is why I'm uneasy just disabling warnings. (This goes for > Jens' compile error case too.) > I agree 100% that those warnings are useful and a life saver sometimes. However, if the buildbots aren't building with that particular version of the compiler, we break it all the time, and never notice it - in particular the person who committed the change isn't responsible for fixing it. I know that first-hand for working on the ARM version (we don't have an ARM buildbot yet, working on it). Especially if committers don't build with that particular version, then any attempt to fix it (if anyone cares enough about it) can only get a rubber-stamp lgtm - and that's potentially dangerous. I once 'fixed' some uninitialized variable error in some code that I didn't know, by initializing it to some value that seemed to make sense, but without a clue whether that was the right thing to do - hopefully the reviewer was sufficiently familiar with the code to actually check that it was the right thing to do. So in practice, enabling -Werror for compilers we're not looking at has about no positive effect for us, and a negative effect for users/potential contributors, so I'll agree with Evan that we should only enable -Werror for compilers we have a buildbot for (but for those, we should absolutely enable it). Antoine > PK > > -- > Chromium Developers mailing list: chromium-dev@googlegroups.com > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
