On Tue, Dec 1, 2009 at 3:11 PM, Dan Kegel <d...@kegel.com> wrote:

> On Tue, Dec 1, 2009 at 2:30 PM, oshima <osh...@chromium.org> wrote:
> > Looks like there are more tests that failing in valgrind test.
> > ...
> > This is not good. Is there any issue if we make a valgrind test fail when
> > the test itself fails?
> > If not, I'd suggest that we exclude them in ui_tetsts.gtext.txt for now
> > (I'll file bugs)
> > and change the test script so that a valgrind test fails when the test
> > itself tails.
> > Any opinion?
>
> It's a great idea.
> This (and getting more tests to pass under valgrind)
> has been on Stuart's post-beta to-do list for some time.
> If somebody else wants to beat him to it, I'm sure
> he wouldn't complain...
>

Ok, I'll file bugs and make changes to ui_tests.gtext.txt.
I'm not falimiar with script side. Is it chrome_tests.py that I need to look
at?
Anyway, I'll work on this once I'm back from ChromeOS team Offsite.

- oshima


> - Dan
>

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev

Reply via email to