Agreed. There are certain situations where conforming to lint expectations leads to messier code. I just checked in a CL that contains a section of lines longer than 80 cols. Trying to wrap these lines would make the definitions unreadable. It's one thing to have lint report zero errors; it's another to muddy the source to achieve that goal. grep'ing through the code, I found hundreds of NOLINTs though, so maybe we're in the minority.
On Wed, Dec 9, 2009 at 3:48 PM, John Abd-El-Malek <[email protected]> wrote: > Lately I've been seeing more and more // NOLINT added to the code. It's > great that people are running lint to make sure that they're following the > guidelines, but I personally find adding comments or gibberish to our code > for tools that are supposed to make the code quality better happy/more > consistent a bit ironic. I also find it distracting when reading the code. > Am I the only one? > > -- > Chromium Developers mailing list: [email protected] > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
