The next build at r35082 passed Chromium Mac compile, so this looks like flakiness in the compile step. I re-opened the tree.
On Mon, Dec 21, 2009 at 00:11, <[email protected]> wrote: > http://build.chromium.org/buildbot/waterfall/ > > Automatically closing tree for "compile" on "Chromium Mac" > > > http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/3750 > > Revision: 35081 > Blame list: [email protected] > > Chromium Mac > Build > 3750<http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/3750> > update > scripts > stdio<http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/3750/steps/shell/logs/stdio> > update > stdio<http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/3750/steps/gclient/logs/stdio> > compile > failed > stdio<http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac/builds/3750/steps/compile/logs/stdio> > > Changed by: *[email protected]* > Changed at: *Sun 20 Dec 2009 22:43:21* > Branch: *src* > Revision: > *35081*<http://src.chromium.org/viewvc/chrome?view=rev&revision=35081> > Changed files: > > - *chrome/app/resources/locale_settings_ja.xtb* > > Comments: > > Remove Sazanami Gothic from IDS_FIXED_FONT_FAMILY and > IDS_SANS_SERIF_FONT_FAMILY. > > It turned out the values of these fields are used for the "Fonts and > Languages" dialog, so use of commas is not allowed. > > On the other hand, IDS_WEB_FONT_FAMILY seems to be used for generating > HTML so use of commas is fine. For instance: > > chrome/browser/dom_ui/chrome_url_data_manager.cc: > > void ChromeURLDataManager::DataSource::SetFontAndTextDirection( > DictionaryValue* localized_strings) { > localized_strings->SetString(L"fontfamily", > l10n_util::GetString(IDS_WEB_FONT_FAMILY)); > > chrome/browser/dom_ui/history_ui.cc: > > SetFontAndTextDirection(&localized_strings); > static const base::StringPiece history_html( > ResourceBundle::GetSharedInstance().GetRawDataResource( > IDR_HISTORY_HTML)); > const std::string full_html = jstemplate_builder::GetI18nTemplateHtml( > history_html, &localized_strings); > > BUG=30758 > TEST=locally ran "LANGUAGE=ja chrome" and confirmed that specified fonts are > shown in > the "Fonts and Languages" dialog, and Japanese pages are rendered with VL > Gothic/PGothic. > > Review URL: http://codereview.chromium.org/502088 > > Properties: > > > -- > Chromium Developers mailing list: [email protected] > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev -- Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
