On Tue, Sep 23, 2008 at 7:43 AM, Gaetano Mendola <[EMAIL PROTECTED]> wrote:
> > Hi all, > one of my duty at work is to perform "code inspection", I tried to do > a 15 mins code inspection > on chromium code as it was our onw code. First of all I have to say > that the code quality is high > (I realy expected this) however I found something that would have been > registered in our code inspection as issues to fix. I don't know if > this is the right place for this kind of comments. [EMAIL PROTECTED] would be a better place. Or you can also file bugs. But, thank you for your investigation, I'll look into these issues. Nicolas > > > Example: > > File hmac.h: > member HMAC::plat_ is a plain pointer (initialized with a new), > at the moment the HMAC CTOR > does not throw exception, so at the moment it's safe. In case in > HMAC it will be added another > pointer (initialized with a new as well)) or the CTOR will throw > an exception then better have > HMAC::plat_ as smart pointer, why do not have it as smar_ptr > from start? > > File histogram.h > class Histogram has DTOR not declared as virtual but one of his > parent class in hierarchy > (StatsCounter) has it declared as virtual, isn't better specify > virtual in histogram.h (after all > is virtual anyway) as well? > > File event_recorder.h > members: > EVENTMSG playback_msg_; > int playback_first_msg_time_; > int playback_start_time_; > > are not initialized in CTOR > > > if you think these kind of comments are welcome or you know a better > place to submit those > please let me know. > > Regards > Gaetano Mendola > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-discuss" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-discuss?hl=en -~----------~----~----~----~------~----~------~--~---
