Hi Patrick,

I'm glad you found the page action API useful. We know about the fact you
cannot modify the page action after you create it, there is a bug on that
assigned to me.

As for this particular page action -- not to steal your thunder, but it has
already been developed and checked in.
For details, see: http://codereview.chromium.org/115536

I should point out that there are *two* RSS subscribe extensions in the
samples directory:

1) subscribe: A regular extension showing a subscribe button in the
toolstrip (which is what you took and morphed into a page action extension).
2) subscribe_ page_action: An extension which implements the RSS
subscription Omnibox icon using a page action (that I checked in a few weeks
ago).

I think it would be better to use subscribe_ page_action as a base, since it
is further along (has a landing page which will eventually allow you to
chose what to use to subscribe with) and hopefully will be shipped with
Chrome at some point.

Best regards,
Finnur

On Tue, Jun 9, 2009 at 06:50, Patrick Stenzel <
[email protected]> wrote:

>
> On 9 Jun., 12:45, MMJB <[email protected]> wrote:
> > Nice extension!
>
> Thanks.
>
> > It would be great if you could support sites providing several feeds
> > (e.g.http://nightly.webkit.org/).
>
> It`s kind of hard without an inspector...
>
> ... but your wish is my command. ;-)
> I added support for multiple feeds on a tab in version 0.1.2.
> Once again Finnurs approach is more ambitious, i just made every found
> feed pop up in a new tab, so for your example there should open 3 new
> tabs when clicking the icon.
>
> Drop-Downs would be beautiful to give the user a choice, but i`d
> rather have them in extensions than in page actions for now... ;-)
>
> Patrick
> >
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Discussion mailing list: [email protected] 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-discuss
-~----------~----~----~----~------~----~------~--~---

Reply via email to