I've just uploaded the fix, so it now plays nicely with other page actions.
On Jun 11, 12:16 pm, Andrew Charlton <[email protected]> wrote: > So every extension gets events for every other extensions page > actions? I had assumed you would only get your own. > > On Jun 11, 12:06 pm, Finnur Thorarinsson <[email protected]> wrote: > > > > > No, the extension just isn't checking in onExecute which page_action was > > clicked on. You pass your page_action id(s) in with enableForTab() and then > > you compare what you get passed back through onExecute (if it isn't one of > > your ids then you don't take action). There is an RSS subscription page > > action (subscribe_page_action) checked into the extension samples directory > > that shows how to do this. > > Another good test case is what happens if you enable a page action for a > > tab, drag that tab out to another window and then click on the page action > > icon. You might also get multiple actions, which you'll also need to handle > > properly. > > > On Wed, Jun 10, 2009 at 16:33, Fernando Belo <[email protected]>wrote: > > > > Very good... Just found two problems right now... > > > 1) When two page actions are available for a page, > > > both are called when clicking. (probably Chrome issue, haven't search bug > > > database to check, will do it later). > > > > 2) When some bookmark is added, I think everything is deleted and > > > recreated > > > inside "Other bookmarks", losing all folder organization. > > > > Well, keep up the good work :) > > > > On Wed, Jun 10, 2009 at 8:16 PM, Andrew Charlton <[email protected]> > > > wrote: > > > > > Just to jump on the page action bandwagon, my Google Bookmarks > > > > extension is now available as a page action. > > > > > Check it out athttp://sites.google.com/site/uniformedopinion/ > > > > > (Warning: this extension will delete your existing bookmarks) --~--~---------~--~----~------------~-------~--~----~ Chromium Discussion mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-discuss -~----------~----~----~----~------~----~------~--~---
