Awesome, thanks Aaron! :) Blessings, Nathan J. Brauer, Founder http://HelloLogic.com
About me: I'm a web developer, and usability, identity, & branding consultant. Email me if you need any help! "The world is a dangerous place, not because of those who do evil, but because of those who look on and do nothing." - Albert Einstein Do Something. Change Your World. Make a Difference. On Tue, Dec 1, 2009 at 11:36 AM, Aaron Boodman <[email protected]> wrote: > Cool, I have some other improvements to make. I'll do these all at the > same time. > > - a > > On Mon, Nov 30, 2009 at 8:22 PM, Nathan J. Brauer <[email protected]> > wrote: > > Great idea! +1 for making this part of the extension :) > > > > On Dec 1, 1:47 am, AlK <[email protected]> wrote: > >> Hi > >> > >> I just modified Google Mail Checker to prevent it to open a new tab if > >> a gmail tab is already opened. > >> > >> I modified the function goToInbox like that : > >> > >> var gmailre = /https?:\/\/mail\.google\.com\//; > >> > >> function goToInbox() { > >> chrome.tabs.getAllInWindow(undefined, function(tabs) { > >> var done = false; > >> for(var i = 0; i < tabs.length; i++) { > >> var tab = tabs[i]; > >> if(tab.url && tab.url.match(gmailre)) { > >> chrome.tabs.update(tab.id, {selected: true}); > >> done = true; > >> break; > >> } > >> } > >> if(!done) { > >> chrome.tabs.create({url: gmail}); > >> } > >> }); > >> > >> } > >> > >> And you should probably change those variables to use the secure http > >> protocol : > >> > >> var gmail = "https://mail.google.com/";; > >> var gmailAtomRef = "https://mail.google.com/mail/feed/atom";; > >> > >> It would be great if the author of the extension applied it ... > > > > -- > > > > You received this message because you are subscribed to the Google Groups > "Chromium-extensions" group. > > To post to this group, send email to > [email protected]. > > To unsubscribe from this group, send email to > [email protected]<chromium-extensions%[email protected]> > . > > For more options, visit this group at > http://groups.google.com/group/chromium-extensions?hl=en. > > > > > > > -- You received this message because you are subscribed to the Google Groups "Chromium-extensions" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/chromium-extensions?hl=en.
