> On 23/07/2015, at 11:28 pm, Miroslav Lichvar <[email protected]> wrote: > > The change looks good, just some comments on the patch and coding style. > > On Thu, Jul 23, 2015 at 10:47:27PM +1200, Bryan Christianson wrote: >> From 2e37782a50a493c39435e221b7eef9c107bd2e86 Mon Sep 17 00:00:00 2001 >> From: Bryan Christianson <[email protected]> > > Is this a valid email address? You might want to set it in git with > this command > > $ git config --global user.email xxxxx
Thanks - I've done that > > Also, does the git send-email command work for you? It would make it > easier for us to review the patches if it wasn't an attachment. I'll see if I can figure it out - should be possible. I'll redo the patch with your suggestions and see how it goes. Just one query - I get a lot of compiler warnings from assigning long to the time_t fields and other places that have assumed long is 32 bit. For now I'm just ignoring but these conversion warnings are potential issues. It'd be a pretty big patch to fix them all but I think it should be done at some point > -- To unsubscribe email [email protected] with "unsubscribe" in the subject. For help email [email protected] with "help" in the subject. Trouble? Email [email protected].
