> On 11/07/2017, at 2:49 AM, Miroslav Lichvar <mlich...@redhat.com> wrote:
> 
> On Mon, Jul 10, 2017 at 08:03:19PM +1200, Bryan Christianson wrote:
>> 
>> +With the exception of macOS 10.12 and earlier, all systems have operating 
>> system
> 
> Would it better to say "all supported systems" ?

OK - I'll change that.

>> +FreeBSD, NetBSD, Solaris and macOS 10.13+).
> 
> Can you please use Oxford comma? The rest of the documentation is
> using it (to the extend I understand it's supposed to be used).

I had never heard of 'Oxford comma' until now :). When I went to school (a long 
long time ago) we were taught that it is wrong to have a comma before the word 
'and' at the end of a list - In fact the Wikipedia entry 
(https://en.wikipedia.org/wiki/Serial_comma) shows that its use is contested. 
However, in the interest of consistent style I shall do as you ask.
> 
> Is it really 5000 ppm on macOS 10.13? There is a testing program
> test/kernel/adjtime, which should print the maximum slew rate. You
> may need to modify it to try a larger offset than 1 second. On an
> older macOS it was 42000 ppm.
> 
> I like that you reused the FreeBSD/NetBSD driver, but if adjtime()
> behaves differently, then maybe it would be better to duplicate the
> fast-slewing functionality in the macOS driver instead.

I was thinking the conservative approach is to use the NetBSD driver for now 
and revisit that once Apple have done something about the adjtime() bug on 
10.13.
I ran the adjtime test on 10.12 and get this result, which is probably the same 
as last time I ran it (10.10 or 10.11). I will test on 10.13 in the morning but 
will have to revisit once adjtime() is fixed.

slew:
      512 us :      0 (16)     0 (256)     0 (4096)     0 (65536)     0 
(1048576)
     1024 us :      0 (16)     0 (256)     0 (4096)     0 (65536)     0 
(1048576)
     2048 us :      0 (16)     0 (256)     0 (4096)     0 (65536)     0 
(1048576)
     4096 us :      0 (16)     0 (256)     0 (4096)     0 (65536)     0 
(1048576)
     8192 us :     16 (16)    40 (256)    40 (4096)    40 (65536)   400 
(1048576)
    16384 us :     16 (16)    80 (256)    80 (4096)    80 (65536)   800 
(1048576)
    32768 us :     16 (16)   120 (256)   120 (4096)   120 (65536)  1200 
(1048576)
    65536 us :     16 (16)   256 (256)   280 (4096)   280 (65536)  2800 
(1048576)
   131072 us :     16 (16)   256 (256)   520 (4096)   520 (65536)  5200 
(1048576)
   262144 us :     16 (16)   256 (256)  1040 (4096)  1040 (65536) 10400 
(1048576)
   524288 us :     16 (16)   256 (256)  2080 (4096)  2080 (65536) 20800 
(1048576)
  1048576 us :     16 (16)   256 (256)  4096 (4096)  4200 (65536) 42000 
(1048576)

Regards
Bryan



Bryan Christianson
br...@whatroute.net




--
To unsubscribe email chrony-dev-requ...@chrony.tuxfamily.org with "unsubscribe" 
in the subject.
For help email chrony-dev-requ...@chrony.tuxfamily.org with "help" in the 
subject.
Trouble?  Email listmas...@chrony.tuxfamily.org.

Reply via email to