On Wed, Oct 04, 2017 at 09:12:24PM +0200, Bernhard M. Wiedemann wrote:
> in order to make builds reproducible.
> See https://reproducible-builds.org/ for why this is good
> and https://reproducible-builds.org/specs/source-date-epoch/
> for the definition of this variable.
That looks useful.
> - split_seconds=`date '+%s'`
> + split_seconds=${SOURCE_DATE_EPOCH:-`date '+%s'`}
> if [ "x$split_seconds" = "x" ]; then
> echo "error: could not get current time, --with-ntp-era option is
> needed"
> exit 1
Could you please rewrite that assignment to use an if-else statement
checking "x$SOURCE_DATE_EPOCH" != "x"? It seems ":-" should be
supported in any POSIX shell, but I though this would be more
consistent with the rest of the code and bit more readable.
Thanks,
--
Miroslav Lichvar
--
To unsubscribe email [email protected] with "unsubscribe"
in the subject.
For help email [email protected] with "help" in the
subject.
Trouble? Email [email protected].
