On Fri, Jun 05, 2020 at 06:23:21PM -0400, Robert Fairley wrote: > On Thu, May 28, 2020 at 5:44 AM Miroslav Lichvar <mlich...@redhat.com> wrote: > > I suspect this breaks the networkd-dispatcher support. IIRC there are no > > arguments passed to the script. > > I see - I should have looked into what'd happen if less than 2 > arguments were passed. Reading on networkd-dispatcher - I think to > best preserve compatibility of the original chrony.nm-dispatcher > file (e.g. so downstreams using networkd-dispatcher don't need to > patch the file), the DHCP bits should be kept in a separate > dispatcher script. I updated the patch to instead add > `chrony.nm-dispatcher.dhcp.in`. That way, `chrony.nm-dispatcher.dhcp` > (after substituting macros) can be packaged downstream as > `/usr/lib/NetworkManager/dispatcher.d/20-chrony-dhcp` or so, or > ignored if not using NetworkManager.
Good idea. Would it make sense to add a suffix to the non-DHCP dispatcher script (e.g .online -> 20-chrony-online) to avoid confusion with the two scripts? Also, could you please rename the default_options variables in the helper and dispatcher scripts to something like default_source_options or default_server_options to make it more clear where the options are used? Thanks, -- Miroslav Lichvar -- To unsubscribe email chrony-dev-requ...@chrony.tuxfamily.org with "unsubscribe" in the subject. For help email chrony-dev-requ...@chrony.tuxfamily.org with "help" in the subject. Trouble? Email listmas...@chrony.tuxfamily.org.
