On Fri, Feb 9, 2024 at 2:28 AM Miroslav Lichvar <mlich...@redhat.com> wrote:
>
> On Thu, Feb 08, 2024 at 02:36:29PM +1100, patrick.oppenlan...@gmail.com wrote:
> > +} tests[] = {
> > + /* leapdb.list is a cut down version of leap-seconds.list */
> > + {3439756800, 34, LEAP_InsertSecond, 0}, /* 1 Jan 2009 */
> > + {3550089600, 35, LEAP_InsertSecond, 0}, /* 1 Jul 2012 */
> > + {3644697600, 36, LEAP_InsertSecond, 0}, /* 1 Jul 2015 */
> > + {3692217600, 37, LEAP_InsertSecond, 0}, /* 1 Jan 2017 */
> > + {34711891200, 36, LEAP_DeleteSecond, 1}, /* 1 Jan 3000 fake in
> > leapdb.list */
>
> This value is too large to fit in 32-bit time_t. I changed it to 1 Jan
> 2020.
Ah, I didn't think of that as all of the platforms I work with are
64-bit time_t and have been for a few years now.
> There was also an issue I found after I updated the other tests. The
> refclock tai option checked only for leapsectz. And there was a new
> issue reported by static analyzer about uninitialized value, probably
> due to not being able to follow the new function pointers.
Thanks for resolving those remaining issues. Looks like I should have
been running a few more tests beyond "make check". How do you run the
static analyser?
Thanks for getting it merged,
Patrick
> Thanks,
>
> --
> Miroslav Lichvar
>
>
> --
> To unsubscribe email chrony-dev-requ...@chrony.tuxfamily.org with
> "unsubscribe" in the subject.
> For help email chrony-dev-requ...@chrony.tuxfamily.org with "help" in the
> subject.
> Trouble? Email listmas...@chrony.tuxfamily.org.
>
--
To unsubscribe email chrony-dev-requ...@chrony.tuxfamily.org with "unsubscribe"
in the subject.
For help email chrony-dev-requ...@chrony.tuxfamily.org with "help" in the
subject.
Trouble? Email listmas...@chrony.tuxfamily.org.
