[ 
https://issues.apache.org/jira/browse/CHUKWA-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12683587#action_12683587
 ] 

Jerome Boulon edited comment on CHUKWA-41 at 3/25/09 11:20 AM:
---------------------------------------------------------------

//escape the newlines from record bodies and then write this record to the log 
file
                  
this.qw.write(RecordConstants.escapeAllButLastRecordSeparator("\n",this.layout.format(event)));

                  if(layout.ignoresThrowable()) {
                          String[] s = event.getThrowableStrRep();
                          if (s != null) {
                                  int len = s.length;
                                  for(int i = 0; i < len; i++) {
                                          this.qw.write(s[i]);
                                          this.qw.write(Layout.LINE_SEP);
                                  }
                          }
                  }



      was (Author: jboulon):
    //escape the newlines from record bodies and then write this record to the 
log file
                  
this.qw.write(RecordConstants.escapeAllButLastRecordSeparator("\n",this.layout.format(event)));

                  if(layout.ignoresThrowable()) {
                          String[] s = event.getThrowableStrRep();
                          if (s != null) {
                                  int len = s.length;
                                  for(int i = 0; i < len; i++) {
                                          this.qw.write(s[i]);
                                          this.qw.write(Layout.LINE_SEP);
                                  }
                          }
                  }

should be 
//escape the newlines from record bodies and then write this record to the log 
file
                  
this.qw.write(RecordConstants.escapeAllButLastRecordSeparator("\n",this.layout.format(event)));

                  if(layout.ignoresThrowable()) {
                          String[] s = event.getThrowableStrRep();
                          if (s != null) {
                                  int len = s.length;
                                  for(int i = 0; i < len; i++) {
                                          this.qw.write(s[i]);
                                          this.qw.write(CTRL_D + "\n");
                                  }
                          }
                  }
  
> ChukwaLog4jAppender does not escape \n for exception
> ----------------------------------------------------
>
>                 Key: CHUKWA-41
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-41
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>            Reporter: Jerome Boulon
>            Assignee: Jerome Boulon
>            Priority: Blocker
>         Attachments: CHUKWA-41.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to