[
https://issues.apache.org/jira/browse/CHUKWA-267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714520#action_12714520
]
Jerome Boulon commented on CHUKWA-267:
--------------------------------------
Eric, this fix this appender but does not fix ChukwaDailyRollingFileAppender.
So instead of duplicating code and propagate errors or code could you create a
singleton class that will be responsible for the registration with our agent.
This should be a singleton class with only a static access method and a private
constructor. That way we can ensure that the code is only at one place and we
don;t have to worry about fixing the same code in several classes.
Also, the same thing could be apply to the way we are writing a log4j event.
ChukwaDailyRollingFileAppender is able to write exceptions, I'm not sure if
yours is doing that. So could you write an helper class that will be reused
cross Chukwa-appender that will do the correct escaping for both standard log4j
event and the ones that contain some exception.
Thanks.
> Collect shuffling information from userlogs/syslog
> --------------------------------------------------
>
> Key: CHUKWA-267
> URL: https://issues.apache.org/jira/browse/CHUKWA-267
> Project: Hadoop Chukwa
> Issue Type: New Feature
> Components: data collection
> Affects Versions: 0.2.0
> Environment: Redhat EL 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.1.2, 0.2.0
>
> Attachments: CHUKWA-267-1.patch, CHUKWA-267.patch
>
>
> Hadoop uses a customized version of log4j appender
> (org.apache.hadoop.mapred.TaskLogAppender) for tasks. Shuffling information
> is written to userlogs/syslog by TaskLogAppender. For chukwa to collect
> shuffling information, we need to write a new TaskLogAppender to do this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
