[ 
https://issues.apache.org/jira/browse/CHUKWA-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717539#action_12717539
 ] 

Ari Rabkin commented on CHUKWA-268:
-----------------------------------

Agent.processCommand() has never handled anything other than "add".  All those 
other commands are implemented in AgentControlSocketListener.  The renaming 
just reflects the status quo. 

We can certainly add more things to the agent control interface. I'm open to 
advice on whether adaptors should have access to the full generality of agent 
functionality, or only to a subset. I initially opted for subset, but mostly 
because it's easier to add things to an interface than to revoke them in the 
future.

> Create an interface to manage all Adaptors
> ------------------------------------------
>
>                 Key: CHUKWA-268
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-268
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: data collection
>    Affects Versions: 0.2.0
>            Reporter: Jerome Boulon
>            Assignee: Ari Rabkin
>             Fix For: 0.2.0
>
>         Attachments: CHUKWA-268.patch
>
>
> Currently the agent manage all adaptors and it's fine however it will be 
> cleaner to have an AdaptorManager interface. The agent will just implement 
> this interface without changing anything, but adaptors will retrieve the 
> manager using ChukwaFactory. This will remove the hard dependency between 
> Agent and adaptors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to