[
https://issues.apache.org/jira/browse/CHUKWA-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718166#action_12718166
]
Mac Yang commented on CHUKWA-278:
---------------------------------
Took a quick look, my two cents,
1. It would be better to get column by name instead of by index
+ String name = rs.getString(4);
+ int type = rs.getInt(5);
2. The following pattern compilation should be outside of the while loop
+ Pattern p = Pattern.compile("(.*)_\\d+");
> Improve post process manager and metric data loader to support data loading
> from pig aggregation
> ------------------------------------------------------------------------------------------------
>
> Key: CHUKWA-278
> URL: https://issues.apache.org/jira/browse/CHUKWA-278
> Project: Hadoop Chukwa
> Issue Type: Improvement
> Components: Data Processors
> Environment: Redhat EL 5.1, Java 6
> Reporter: Eric Yang
> Assignee: Eric Yang
> Fix For: 0.2.0
>
> Attachments: CHUKWA-278-1.patch, CHUKWA-278-2.patch, CHUKWA-278.patch
>
>
> The current post process manager loads sequence file to database only.
> Ideally, the post process manager should be able to load data into different
> data loader. Hence, DataLoaderFactory should be defined as an interface or
> abstract class for third party to implement their own data loader. The
> current implementation of pig aggregator generates down sampled data as
> different record type. There should be a new capability for Metric Data
> Loader to identify table partition base on record type.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
