[ 
https://issues.apache.org/jira/browse/CHUKWA-25?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724711#action_12724711
 ] 

Eric Yang commented on CHUKWA-25:
---------------------------------

Is there a test case being planned at:

+//    fstat = fileSys.getFileStatus(OUTPUT_DIR);
+   // assertTrue(fstat.);

If not, could we remove it.

+  static final Path OUTPUT_DIR = new Path("/chukwa/archives/");
+  public void testArchiving() throws Exception {
+    
+
+    System.out.println("starting archive test");

Probably line break this correctly if possible.  

The patch looks good, otherwise.

> chukwa archiving should group by cluster name
> ---------------------------------------------
>
>                 Key: CHUKWA-25
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-25
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: Data Processors
>    Affects Versions: 0.3.0
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>             Fix For: 0.3.0
>
>         Attachments: CHUKWA-25.patch
>
>
> The chukwa archivers ought to have an option for grouping data by cluster 
> name.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to