[
https://issues.apache.org/jira/browse/CHUKWA-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734037#action_12734037
]
Ari Rabkin commented on CHUKWA-270:
-----------------------------------
Patch looks good. My one hesitation is that I noticed you use log.error for
the usage statement. This may not be ideal -- I think that really *should* go
to standard out. Thoughts?
For your reference: when you have a patch ready for review, it's helpful to
mark the patch as available, using the "submit patch" link on the left. This
makes it easy for reviewers to find reviewable patches, and for committers to
find committable ones..
> undesired ChukwaAgentController message injected to stdout of the running
> program
> ---------------------------------------------------------------------------------
>
> Key: CHUKWA-270
> URL: https://issues.apache.org/jira/browse/CHUKWA-270
> Project: Hadoop Chukwa
> Issue Type: Improvement
> Components: data collection
> Environment: Redhat EL 5.1, Java 6
> Reporter: Eric Yang
> Assignee: rushin barot
> Attachments: CHUKWA-270.patch, ChukwaAgentController.java
>
>
> Agent Controller currently prints it's messages to the stdout of the running
> program. This should be changed to using logger to prevent messages showing
> up in the unexpected places.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
