[
https://issues.apache.org/jira/browse/CHUKWA-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756287#action_12756287
]
Ari Rabkin commented on CHUKWA-97:
----------------------------------
The refactoring I did shouldn't have changed the code path in
FileTailingAdaptor; it just refactored some code into a new base class.
We do have a test case for rotation. More tests and documentation are still
welcome, of course.
> FileTailingAdaptor.tailFile should be refactored and made more flexible
> -----------------------------------------------------------------------
>
> Key: CHUKWA-97
> URL: https://issues.apache.org/jira/browse/CHUKWA-97
> Project: Hadoop Chukwa
> Issue Type: Improvement
> Components: data collection
> Reporter: Ari Rabkin
> Assignee: Ari Rabkin
> Priority: Minor
> Attachments: CHUKWA-97.patch
>
>
> FileTailingAdaptor.tailFile() is 150 lines long, and scary. An awful lot lof
> policy, for things like log file rotation, is hardcoded and shouldn't be.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
