[ 
https://issues.apache.org/jira/browse/CHUKWA-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773615#action_12773615
 ] 

Eric Yang commented on CHUKWA-345:
----------------------------------

+1 to commit this patch.

Serialization format and protocol format are somewhat coupled.  It's not 
possible to use certain protocols if the serialization format uses the same 
keywords.  For example, GET / HTTP/1.0\r\n\r\n maybe required to be escaped in 
serialization format, if Content-Length: is not honored, and HTTP protocol is 
chosen to wrap around the serialization protocol.  The same escaping rules 
apply to any transport protocol and serialization format.  Hence it's best to 
define the serialization format and protocol upfront.  The implementation would 
be easier and less error prone.  However, the protocol and serialization 
changes should not be in scope of this jira.

> Chunk.application and Chunk.streamName are redundant
> ----------------------------------------------------
>
>                 Key: CHUKWA-345
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-345
>             Project: Hadoop Chukwa
>          Issue Type: Bug
>          Components: data collection
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>         Attachments: CHUKWA-345.patch
>
>
> The chunk interface has both an "application" field and a "stream name" 
> field. But they map to the same value.  Should cut one of those names, for 
> clarity.
> I think "application" is the less descriptive name, and should be cut.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to