[ 
https://issues.apache.org/jira/browse/CHUKWA-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834184#action_12834184
 ] 

Gerrit Jansen van Vuuren commented on CHUKWA-454:
-------------------------------------------------

Hi,

I've made the changes, hope the spaces are 2 and not tab, I've configured 
eclipse to use only spaces and not tabs, checked also with sed for tab 
occurances didn't find any in the new patch.

I hope you don't mind but I've extended the TestDirTailingAdaptor test with 
another method which is basically a copy of the existing test method, just with 
the extra lines of adding filters and a file that should be ignored by the 
filter. This assures that the filtering works properly.



> DirTailingAdaptor Add option to Filter files.
> ---------------------------------------------
>
>                 Key: CHUKWA-454
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-454
>             Project: Hadoop Chukwa
>          Issue Type: New Feature
>          Components: data collection
>    Affects Versions: 0.4.0
>            Reporter: Gerrit Jansen van Vuuren
>            Priority: Minor
>             Fix For: 0.4.0
>
>         Attachments: CHUKWA-454-v0.1.patch
>
>
> I would like to be able to point the DirTailingAdaptor at a directory but 
> only have it tail files matching to a certain pattern. 
> So I've made a change that allows the adaptor to recieve an optional filter 
> parameter and use the org.apache.commons.io.filefilter.WildcardFileFilter 
> class to filter out files.
> This allows you to for example point the adaptor at a tomcat log directory 
> and not have it tail catalina.out logs etc. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to