[ 
https://issues.apache.org/jira/browse/CHUKWA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bill Graham updated CHUKWA-469:
-------------------------------

    Attachment: CHUKWA-469.1.patch

Attaching CHUKWA-469.1.patch, which includes JMSAdaptor and supporting classes 
as described above. There are many unit tests to look at for usage of this 
adaptor. Once it's incorporated I'll can of course add documentation to the 
site as well.

My previous comment above was incorrect though, as I believe this 
implementation is bound to having an ActiveMQ broker. I've introduced one 
dependency into ivy, which is activemq-core. I've also tried to isolate the 
dependency so it could be subclassed and swapped out. In {{JMSAdaptor}} this 
method is the one place where AMQ is integrated:

{noformat} 
protected ConnectionFactory initializeConnectionFactory(String brokerURL) {
    return new ActiveMQConnectionFactory(brokerURL);
}
{noformat}

Any suggestions for how to best handle this dependency? We could say that 
JMSAdaptor by default uses AMQ, but it could be subclassed for other JMS 
providers. Or we could make JMSAdaptor abstact and have a concrete 
ActiveMQJMSAdaptor subclass.

> Create a JMSAdaptor
> -------------------
>
>                 Key: CHUKWA-469
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-469
>             Project: Hadoop Chukwa
>          Issue Type: New Feature
>            Reporter: Bill Graham
>            Assignee: Bill Graham
>         Attachments: CHUKWA-469.1.patch
>
>
> We should have a JMSAdaptor that listens to a JMS queue for messages to send 
> to a collector.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to